Skip to content

[EVOLUTION_X] Move stored products in SimDataFormats/{Associations,Calo*,Track*,Vertex} to io_v1 namespace#50416

Merged
cmsbuild merged 1 commit into
cms-sw:CMSSW_16_1_EVOLUTION_Xfrom
makortel:evolutionSimDataFormats1
Mar 25, 2026
Merged

[EVOLUTION_X] Move stored products in SimDataFormats/{Associations,Calo*,Track*,Vertex} to io_v1 namespace#50416
cmsbuild merged 1 commit into
cms-sw:CMSSW_16_1_EVOLUTION_Xfrom
makortel:evolutionSimDataFormats1

Conversation

@makortel
Copy link
Copy Markdown
Contributor

PR description:

This PR moves stored classes in the said SimDataFormats packages to the io_v1 namespace

Resolves cms-sw/framework-team#1980

PR validation:

Code compiles

@makortel
Copy link
Copy Markdown
Contributor Author

type evolution

@makortel
Copy link
Copy Markdown
Contributor Author

assign core

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 15, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50416/48524

@cmsbuild
Copy link
Copy Markdown
Contributor

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @makortel for CMSSW_16_1_EVOLUTION_X.

It involves the following packages:

  • AnalysisDataFormats/TrackInfo (analysis)
  • FastSimDataFormats/NuclearInteractions (fastsim)
  • SimDataFormats/Associations (simulation)
  • SimDataFormats/CaloAnalysis (simulation)
  • SimDataFormats/CaloHit (simulation)
  • SimDataFormats/Track (simulation)
  • SimDataFormats/TrackingAnalysis (simulation)
  • SimDataFormats/TrackingHit (simulation)
  • SimDataFormats/Vertex (simulation)

@Dr15Jones, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @smuzaffar, @ssekmen, @tvami can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @Fedespring, @HuguesBrun, @ReyerBand, @VinInn, @VourMa, @abbiendi, @apsallid, @bsunanda, @cericeci, @denizsun, @elusian, @fabiocos, @felicepantaleo, @fsimone91, @jhgoh, @llunerti, @martinamalberti, @missirol, @mmasciov, @mmusich, @mtosi, @rovere, @salimcerci, @sbein, @thomreis, @trocino, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94e8eb/51975/summary.html
COMMIT: 72dfd30
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-13-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50416/51975/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

----- Begin Fatal Exception 15-Mar-2026 18:14:27 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::Wrapper<std::vector<PCaloHit> >
  edm::Wrapper<std::vector<PSimHit> >
  edm::Wrapper<std::vector<SimTrack> >
  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<PCaloHit>
  std::vector<PSimHit>
  std::vector<SimTrack>
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  std::vector<PCaloHit> (read from input)
  std::vector<PSimHit> (read from input)
  std::vector<SimTrack> (read from input)
  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  PCaloHits_g4SimHits_CaloHitsTk_SIM.
  PCaloHits_g4SimHits_CastorBU_SIM.
  PCaloHits_g4SimHits_CastorFI_SIM.
  PCaloHits_g4SimHits_CastorPL_SIM.
  PCaloHits_g4SimHits_CastorTU_SIM.
  PCaloHits_g4SimHits_ChamberHits_SIM.
  PCaloHits_g4SimHits_EcalHitsEB_SIM.
  PCaloHits_g4SimHits_EcalHitsEE_SIM.
  PCaloHits_g4SimHits_EcalHitsES_SIM.
  PCaloHits_g4SimHits_EcalTBH4BeamHits_SIM.
  PCaloHits_g4SimHits_FibreHits_SIM.
  PCaloHits_g4SimHits_HFNoseHits_SIM.
  PCaloHits_g4SimHits_HGCHitsEE_SIM.
  PCaloHits_g4SimHits_HGCHitsHEback_SIM.
  PCaloHits_g4SimHits_HGCHitsHEfront_SIM.
  PCaloHits_g4SimHits_HcalHits_SIM.
  PCaloHits_g4SimHits_HcalTB06BeamHits_SIM.
  PCaloHits_g4SimHits_WedgeHits_SIM.
  PCaloHits_g4SimHits_ZDCHITS_SIM.
  PSimHits_g4SimHits_BCM1FHits_SIM.
  PSimHits_g4SimHits_BHMHits_SIM.
  PSimHits_g4SimHits_BSCHits_SIM.
  PSimHits_g4SimHits_FP420SI_SIM.
  PSimHits_g4SimHits_FastTimerHitsBarrel_SIM.
  PSimHits_g4SimHits_FastTimerHitsEndcap_SIM.
  PSimHits_g4SimHits_MuonCSCHits_SIM.
  PSimHits_g4SimHits_MuonDTHits_SIM.
  PSimHits_g4SimHits_MuonGEMHits_SIM.
  PSimHits_g4SimHits_MuonME0Hits_SIM.
  PSimHits_g4SimHits_MuonRPCHits_SIM.
  PSimHits_g4SimHits_PLTHits_SIM.
  PSimHits_g4SimHits_TotemHitsRP_SIM.
  PSimHits_g4SimHits_TotemHitsT1_SIM.
  PSimHits_g4SimHits_TotemHitsT2Gem_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBLowTof_SIM.
  SimTracks_g4SimHits__SIM.
  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 15-Mar-2026 18:26:37 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'edm::RangeMap<CSCDetId,edm::OwnVector<CSCSegment,edm::ClonePolicy<CSCSegment> >,edm::ClonePolicy<CSCSegment> >'
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 15-Mar-2026 18:18:50 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::HepMCProduct
  edm::Wrapper<edm::HepMCProduct>
  edm::Wrapper<std::vector<PCaloHit> >
  edm::Wrapper<std::vector<PSimHit> >
  edm::Wrapper<std::vector<SimTrack> >
  std::vector<PCaloHit>
  std::vector<PSimHit>
  std::vector<SimTrack>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  edm::HepMCProduct (read from input)
  std::vector<PCaloHit> (read from input)
  std::vector<PSimHit> (read from input)
  std::vector<SimTrack> (read from input)

Missing dictionaries are associated with these branch names:

  PCaloHits_fastSimProducer_EcalHitsEB_RECOBEFMIX.
  PCaloHits_fastSimProducer_EcalHitsEE_RECOBEFMIX.
  PCaloHits_fastSimProducer_EcalHitsES_RECOBEFMIX.
  PCaloHits_fastSimProducer_HcalHits_RECOBEFMIX.
  PSimHits_MuonSimHits_MuonCSCHits_RECOBEFMIX.
  PSimHits_MuonSimHits_MuonDTHits_RECOBEFMIX.
  PSimHits_MuonSimHits_MuonRPCHits_RECOBEFMIX.
  PSimHits_fastSimProducer_TrackerHits_RECOBEFMIX.
  SimTracks_fastSimProducer_MuonSimTracks_RECOBEFMIX.
  SimTracks_fastSimProducer__RECOBEFMIX.
  edmHepMCProduct_generatorSmeared__RECOBEFMIX.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

Failed AddOn Tests

----- Begin Fatal Exception 15-Mar-2026 18:02:18 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it&xrdcl.requuid=e585d198-e8eb-41e1-ad68-6ec2ace7f212
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

Comment thread SimDataFormats/CaloAnalysis/src/classes_def.xml Outdated
Comment thread SimDataFormats/CaloAnalysis/src/classes_def.xml Outdated
Comment thread SimDataFormats/Vertex/interface/SimVertex.h Outdated
@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #50416 was updated. @Dr15Jones, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @smuzaffar, @ssekmen, @tvami can you please check and sign again.

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94e8eb/52201/summary.html
COMMIT: 4e34aee
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-23-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50416/52201/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 5 errors in the following unit tests:

---> test testTauEmbeddingWorkflow2018 had ERRORS
---> test testTauEmbeddingWorkflow2022postEE had ERRORS
---> test testTauEmbeddingWorkflow2017 had ERRORS
and more ...

Failed RelVals

----- Begin Fatal Exception 24-Mar-2026 18:05:36 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 24-Mar-2026 18:06:19 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 24-Mar-2026 18:05:53 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

Failed AddOn Tests

----- Begin Fatal Exception 24-Mar-2026 18:02:08 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213xrootd-redic.pi.infn.it&xrdcl.requuid=2930b562-9204-40c0-93c7-cda094c0e60c
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 24-Mar-2026 18:01:36 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Calling OutputModuleCore::keepThisBranch, checking dictionaries for kept types
Exception Message:
No data dictionary found for the following classes:

  GlobalObjectMapRecord

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 24-Mar-2026 18:01:45 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_Fake2_DATA.root'
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake2_DATA.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake2_DATA.root.
      [c] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@makortel
Copy link
Copy Markdown
Contributor Author

ignore tests-rejected with manual override

Test failures will be addressed later

@makortel
Copy link
Copy Markdown
Contributor Author

+core

@makortel
Copy link
Copy Markdown
Contributor Author

ignore tests-rejected with manual-override

@tvami
Copy link
Copy Markdown
Contributor

tvami commented Mar 24, 2026

+1

@mandrenguyen
Copy link
Copy Markdown
Contributor

merge

@cmsbuild cmsbuild merged commit 9d4c6df into cms-sw:CMSSW_16_1_EVOLUTION_X Mar 25, 2026
6 of 9 checks passed
@makortel makortel deleted the evolutionSimDataFormats1 branch March 25, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants